Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

priority of EvalIterHook shold be lower then IterTimerHook #473

Merged
merged 3 commits into from
Aug 11, 2021
Merged

priority of EvalIterHook shold be lower then IterTimerHook #473

merged 3 commits into from
Aug 11, 2021

Conversation

yivan-WYYGDSG
Copy link
Contributor

Motivation

when use EvalIterHook in _non_dist_train in .mmedit/apis/train.py, it will raise keyError since the key 'data_time' is not exsist

Modification

set the priority of EvalIterHook lower then IterTimerHook

@ckkelvinchan ckkelvinchan mentioned this pull request Aug 10, 2021
Closed
@ckkelvinchan
Copy link
Member

Hi, may I ask what command did you use when you encounter this error?

@codecov
Copy link

codecov bot commented Aug 10, 2021 •
edited
Loading

Codecov Report

Merging #473 (956a622) into master (f9c9a95) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   80.56%   80.38%   -0.19%     
==========================================
  Files         190      190              
  Lines       10338    10262      -76     
  Branches     1533     1533              
==========================================
- Hits         8329     8249      -80     
- Misses       1780     1783       +3     
- Partials      229      230       +1
Flag Coverage Δ
unittests 80.36% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/apis/train.py 18.00% <ø> (ø)
...ackbones/encoder_decoders/pconv_encoder_decoder.py 43.47% <0.00%> (-2.36%) ⬇️
mmedit/models/base.py 82.75% <0.00%> (-2.09%) ⬇️
...ls/components/stylegan2/generator_discriminator.py 84.93% <0.00%> (-1.21%) ⬇️
...ones/encoder_decoders/two_stage_encoder_decoder.py 53.84% <0.00%> (-1.16%) ⬇️
...dels/backbones/encoder_decoders/encoders/resnet.py 66.01% <0.00%> (-0.97%) ⬇️
...s/backbones/encoder_decoders/gl_encoder_decoder.py 81.48% <0.00%> (-0.67%) ⬇️
mmedit/datasets/pipelines/normalization.py 88.88% <0.00%> (-0.59%) ⬇️
mmedit/apis/test.py 24.75% <0.00%> (-0.51%) ⬇️
mmedit/models/mattors/indexnet.py 84.37% <0.00%> (-0.48%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c9a95...956a622. Read the comment docs.

zhouzaida
zhouzaida reviewed Aug 11, 2021
View reviewed changes
mmedit/apis/train.py Outdated Show resolved Hide resolved
@innerlee innerlee merged commit 2006471 into open-mmlab:master Aug 11, 2021
@yivan-WYYGDSG yivan-WYYGDSG deleted the xyf branch August 12, 2021 00:34
@ckkelvinchan ckkelvinchan mentioned this pull request Aug 15, 2021
Closed
@innerlee innerlee mentioned this pull request Sep 14, 2021
Closed
Yshuo-Li pushed a commit to Yshuo-Li/mmediting that referenced this pull request Jul 15, 2022
@yivan-WYYGDSG @innerlee @zhouzaida
priority of EvalIterHook shold be lower then IterTimerHook (open-mmla…
2cb9af4 
…b#473)

* priority of EvalIterHook shold be lower then IterTimerHook

* Update mmedit/apis/train.py

Co-authored-by: Zaida Zhou <[email protected]>

* Fix linting

Co-authored-by: lizz <[email protected]>
Co-authored-by: Zaida Zhou <[email protected]>
Co-authored-by: lizz <[email protected]>
@OpenMMLab-Coodinator
Copy link

Hi @yivan-WYYGDSG ！First of all, we want to express our gratitude for your significant PR in this project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida left review comments

@ckkelvinchan ckkelvinchan ckkelvinchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yivan-WYYGDSG @ckkelvinchan @OpenMMLab-Coodinator @zhouzaida @innerlee